Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 #98

Merged
merged 1 commit into from
Nov 19, 2023
Merged

v4.0.0 #98

merged 1 commit into from
Nov 19, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Nov 18, 2023

  • Breaking: Fix a footgun in the EventListener type. EventListener::new() now no longer takes an &Event as an argument, and EventListener::listen() takes the &Event as an argument. Hopefully this should prevent .awaiting on a listener without making sure it's listening first. (Fix the EventListener::new() footgun #94)

Signed-off-by: John Nunley <[email protected]>
Copy link
Member

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@notgull notgull merged commit 531c106 into master Nov 19, 2023
9 checks passed
@notgull notgull deleted the notgull/next branch November 19, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants