Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NtAssociateWaitCompletionPacket for waitable handles on Windows 10 #141

Open
notgull opened this issue Aug 22, 2023 · 0 comments · May be fixed by #210
Open

Use NtAssociateWaitCompletionPacket for waitable handles on Windows 10 #141

notgull opened this issue Aug 22, 2023 · 0 comments · May be fixed by #210

Comments

@notgull
Copy link
Member

notgull commented Aug 22, 2023

This function is significantly more efficient in comparison to the current strategy used for polling waitable handles.

notgull added a commit to smol-rs/async-process that referenced this issue Aug 10, 2024
In async-process, we have a backend that assumes that child processes
are object that can be `.await`ed on, rather than just being dependent
on signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.

At the moment, the backend for `Waitable` in `async-io` is just backed
by a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.

As a side effect, this removes our dependency on `windows-sys`.

Signed-off-by: John Nunley <[email protected]>
notgull added a commit to smol-rs/async-process that referenced this issue Aug 10, 2024
In async-process, we have a backend that assumes that child processes
are object that can be `.await`ed on, rather than just being dependent
on signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.

At the moment, the backend for `Waitable` in `async-io` is just backed
by a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.

As a side effect, this removes our dependency on `windows-sys`.

Signed-off-by: John Nunley <[email protected]>
notgull added a commit to smol-rs/async-process that referenced this issue Aug 10, 2024
In async-process, we have a backend that assumes that child processes
are object that can be `.await`ed on, rather than just being dependent
on signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.

At the moment, the backend for `Waitable` in `async-io` is just backed
by a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.

As a side effect, this removes our dependency on `windows-sys`.

Signed-off-by: John Nunley <[email protected]>
notgull added a commit to smol-rs/async-process that referenced this issue Aug 10, 2024
In async-process, we have a backend that assumes that child processes
are object that can be `.await`ed on, rather than just being dependent
on signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.

At the moment, the backend for `Waitable` in `async-io` is just backed
by a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.

As a side effect, this removes our dependency on `windows-sys`.

Signed-off-by: John Nunley <[email protected]>
notgull added a commit to smol-rs/async-process that referenced this issue Aug 23, 2024
In async-process, we have a backend that assumes that child processes
are object that can be `.await`ed on, rather than just being dependent
on signals. At the moment it is only used with Linux and pidfd. Now, it
is used with Windows and the waitable process backend.

At the moment, the backend for `Waitable` in `async-io` is just backed
by a blocking threadpool. However it may also be possible to have it use
IOCP too with little extra overhead. See smol-rs/polling#141 for more
information.

As a side effect, this removes our dependency on `windows-sys`.

Signed-off-by: John Nunley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant