Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee: better handle addr for new frame version #870

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

thvdveld
Copy link
Contributor

@thvdveld thvdveld commented Dec 7, 2023

The standard defines when addresses and pan ids are present or not. This depends on the frame version. smoltcp supported old versions (2003 and 2006). However, newer versions are more complicated. This adds better handling for new versions.

The standard defines when addresses and pan ids are present or not. This
depends on the frame version. smoltcp supported old versions (2003 and
2006). However, newer versions are more complicated. This adds better
handling for new versions.
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (481246d) 79.63% compared to head (26d949a) 79.58%.

Files Patch % Lines
src/wire/ieee802154.rs 70.09% 32 Missing ⚠️
src/iface/interface/sixlowpan.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   79.63%   79.58%   -0.06%     
==========================================
  Files          78       78              
  Lines       28074    28120      +46     
==========================================
+ Hits        22358    22380      +22     
- Misses       5716     5740      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Dec 7, 2023
Merged via the queue into smoltcp-rs:main with commit e893a17 Dec 7, 2023
14 checks passed
@thvdveld thvdveld deleted the ieee-addr-fixes branch December 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant