Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iface: rename IpPacket to Packet #873

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

thvdveld
Copy link
Contributor

IpPacket/Ipv6Packet/Ipv4Packet were already defined in src/wire/*. It is confusing to use them together with the version in src/iface/. In some cases the compiler or clippy complained about ambiguity.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (c647a32) 79.74% compared to head (ca755d7) 79.74%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/iface/interface/mod.rs 27.77% 13 Missing ⚠️
src/iface/packet.rs 66.66% 2 Missing ⚠️
src/iface/interface/ipv4.rs 90.90% 1 Missing ⚠️
src/iface/interface/ipv6.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   79.74%   79.74%   -0.01%     
==========================================
  Files          78       78              
  Lines       28137    28131       -6     
==========================================
- Hits        22439    22433       -6     
  Misses       5698     5698              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Dec 12, 2023
Merged via the queue into smoltcp-rs:main with commit 386ee1d Dec 12, 2023
11 checks passed
@thvdveld thvdveld deleted the ip-packet-rename branch December 12, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant