Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum support for iOS #896

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add minimum support for iOS #896

merged 1 commit into from
Jan 15, 2024

Conversation

Chilledheart
Copy link
Contributor

@Chilledheart Chilledheart commented Jan 13, 2024

Below is my usage of smoltcp on iOS:

Tested on iOS 17 and iOS on ARM macOS.

The minimum requirement for smoltcp is making it compile when targeting iOS, so there is the patch.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d185a37) 79.82% compared to head (ccfff8b) 79.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   79.82%   79.91%   +0.08%     
==========================================
  Files          80       80              
  Lines       28053    28232     +179     
==========================================
+ Hits        22394    22561     +167     
- Misses       5659     5671      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Jan 15, 2024
Merged via the queue into smoltcp-rs:main with commit 67f0528 Jan 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants