Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lambda keyword args, improve errors, and nested madness #136

Merged
merged 17 commits into from
May 30, 2022
Merged

fix: Lambda keyword args, improve errors, and nested madness #136

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
096ec31
Merge pull request #141 from snakemake/dev
johanneskoester Mar 3, 2022
6496d5f
chore: release 0.6.0
github-actions[bot] Mar 3, 2022
d233dfa
Merge pull request #142 from snakemake/release-v0.6.0
johanneskoester Mar 3, 2022
a9b3bc2
allow keyword args in lambda
mbhall88 Feb 17, 2022
6efe830
improve line number error reporting
mbhall88 Feb 17, 2022
7fe08de
add failing test for #126
mbhall88 Feb 17, 2022
7f04f24
Update poetry.lock
mbhall88 May 11, 2022
4eddbe1
Update test_formatter.py
mbhall88 May 11, 2022
e308104
improved handling of varied indentation comments
mbhall88 May 12, 2022
7b01968
Update CHANGELOG.md
mbhall88 May 12, 2022
f044158
update import odering
mbhall88 May 12, 2022
72d1559
Fix black line numbering
bricoletc May 14, 2022
a5b9a7d
add two tests for nested snakemake code
mbhall88 May 19, 2022
dd39ae8
fix comment indenting in nested statements
mbhall88 May 20, 2022
34e2927
add retries keyword
mbhall88 May 20, 2022
a4add38
tidy up
mbhall88 May 20, 2022
ebc486e
add test case for nested rule with run
mbhall88 May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [unreleased]

### Fixed
* Keyword argument lambdas are now allowed inside rules [[#135][135]]
* Improve reported line number in Snakefile when black fails to parse [[#127][127]]
* Better handling of snakemake code inside nested if-else statements with comments at differing indentation levels [[#126][126]]

## [0.6.0](https://www.github.com/snakemake/snakefmt/compare/v0.5.0...v0.6.0) (2022-03-03)

### Added

* Support for `template_engine` keyword. **This requires bumping our minimum python version to 3.7 to allow for snakemake v7.**
Expand Down Expand Up @@ -251,4 +258,7 @@ is 40 character long, the line is 48 characters long. However, we were only pass
[116]: https://github.com/snakemake/snakefmt/pull/116
[118]: https://github.com/snakemake/snakefmt/issues/118
[121]: https://github.com/snakemake/snakefmt/issues/121
[126]: https://github.com/snakemake/snakefmt/issues/126
[127]: https://github.com/snakemake/snakefmt/issues/127
[131]: https://github.com/snakemake/snakefmt/pull/131
[135]: https://github.com/snakemake/snakefmt/issues/135
Loading