Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deeptools plot correlation #3137

Merged
merged 60 commits into from
Aug 27, 2024

Conversation

tdayris
Copy link
Contributor

@tdayris tdayris commented Aug 26, 2024

QC

While the contributions guidelines are more extensive, please particularly ensure that:

  • test.py was updated to call any added or updated example rules in a Snakefile
  • input: and output: file paths in the rules can be chosen arbitrarily
  • wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:)
  • temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to
  • the meta.yaml contains a link to the documentation of the respective tool or command under url:
  • conda environments use a minimal amount of channels and packages, in recommended ordering

Summary by CodeRabbit

  • New Features

    • Introduced environment.linux-64.pin.txt for consistent Conda environment setup on Linux 64-bit.
    • Added environment.yaml for configuring Conda environment with DeepTools dependencies.
    • Launched meta.yaml providing essential metadata for the Deeptools Plot Correlation tool.
    • Created a Snakemake rule for testing correlation plot generation.
    • Developed wrapper.py to facilitate plotting with customizable parameters.
    • Implemented a new test function for validating plot correlation functionality.
  • Documentation

    • Enhanced documentation within new files to support user setup and usage instructions.

tdayris and others added 30 commits September 21, 2020 09:16
* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
* Add autobump action

* fix paths

* dbg

* dbg branch

* add checkout

* dbg

* trigger rerun

* entity regex and add label

* dbg

* Update autobump.yml

* Update autobump.yml
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented Aug 26, 2024

Walkthrough

The changes introduce several new files related to the DeepTools Plot Correlation tool, including configuration files for Conda environments (environment.linux-64.pin.txt, environment.yaml), a metadata file (meta.yaml), a Snakemake workflow definition (Snakefile), and a wrapper script (wrapper.py). Additionally, a test function for validating the plotcorrelation functionality is added to test.py. These files collectively enhance the setup, configuration, and testing of the correlation plotting capabilities.

Changes

Files Change Summary
bio/deeptools/plotcorrelation/environment.linux-64.pin.txt, bio/deeptools/plotcorrelation/environment.yaml New files specifying Conda environment configurations, including package dependencies and channels for bioinformatics tools.
bio/deeptools/plotcorrelation/meta.yaml New file providing metadata and configuration details for the DeepTools Plot Correlation tool, including input/output specifications.
bio/deeptools/plotcorrelation/test/Snakefile, bio/deeptools/plotcorrelation/wrapper.py New files implementing a Snakemake rule for correlation plotting and a wrapper for the plotCorrelation command, respectively.
test.py New test function added to validate the execution of the plotcorrelation functionality within the DeepTools suite.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between df7e2bf and 48c6c8d.

Files selected for processing (6)
  • bio/deeptools/plotcorrelation/environment.linux-64.pin.txt (1 hunks)
  • bio/deeptools/plotcorrelation/environment.yaml (1 hunks)
  • bio/deeptools/plotcorrelation/meta.yaml (1 hunks)
  • bio/deeptools/plotcorrelation/test/Snakefile (1 hunks)
  • bio/deeptools/plotcorrelation/wrapper.py (1 hunks)
  • test.py (1 hunks)
Files skipped from review due to trivial changes (2)
  • bio/deeptools/plotcorrelation/environment.linux-64.pin.txt
  • bio/deeptools/plotcorrelation/environment.yaml
Additional context used
Path-based instructions (2)
bio/deeptools/plotcorrelation/wrapper.py (2)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.


Pattern **/wrapper.py: Do not complain about use of undefined variable called snakemake.

test.py (1)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.

Ruff
bio/deeptools/plotcorrelation/wrapper.py

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


16-16: Undefined name snakemake

(F821)


17-17: Undefined name snakemake

(F821)


20-20: Undefined name snakemake

(F821)


23-23: Undefined name snakemake

(F821)

Additional comments not posted (4)
bio/deeptools/plotcorrelation/test/Snakefile (1)

1-15: LGTM!

The rule is well-defined and follows Snakemake conventions.

The code changes are approved.

bio/deeptools/plotcorrelation/meta.yaml (1)

1-17: LGTM!

The metadata is well-defined and follows the conventions for Snakemake wrappers.

The code changes are approved.

bio/deeptools/plotcorrelation/wrapper.py (1)

1-34: LGTM!

The wrapper script is well-defined and follows the conventions for Snakemake wrappers. The static analysis tool's warnings about undefined snakemake references can be ignored as snakemake is assumed to be defined in this context.

The code changes are approved.

Tools
Ruff

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


16-16: Undefined name snakemake

(F821)


17-17: Undefined name snakemake

(F821)


20-20: Undefined name snakemake

(F821)


23-23: Undefined name snakemake

(F821)

test.py (1)

2844-2855: LGTM!

The function test_deeptools_plotcorrelation is correctly implemented. Ensure that it is properly integrated into the test suite.

The code changes are approved.

Run the following script to verify the integration of the test function into the test suite:

bio/deeptools/plotcorrelation/test/Snakefile Outdated Show resolved Hide resolved
bio/deeptools/plotcorrelation/meta.yaml Outdated Show resolved Hide resolved
bio/deeptools/plotcorrelation/wrapper.py Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 48c6c8d and c432fed.

Files selected for processing (4)
  • bio/deeptools/plotcorrelation/meta.yaml (1 hunks)
  • bio/deeptools/plotcorrelation/test/Snakefile (1 hunks)
  • bio/deeptools/plotcorrelation/wrapper.py (1 hunks)
  • test.py (1 hunks)
Files skipped from review due to trivial changes (2)
  • bio/deeptools/plotcorrelation/meta.yaml
  • test.py
Files skipped from review as they are similar to previous changes (1)
  • bio/deeptools/plotcorrelation/test/Snakefile
Additional context used
Path-based instructions (1)
bio/deeptools/plotcorrelation/wrapper.py (2)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.


Pattern **/wrapper.py: Do not complain about use of undefined variable called snakemake.

Ruff
bio/deeptools/plotcorrelation/wrapper.py

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


16-16: Undefined name snakemake

(F821)


17-17: Undefined name snakemake

(F821)


20-20: Undefined name snakemake

(F821)


23-23: Undefined name snakemake

(F821)

Additional comments not posted (5)
bio/deeptools/plotcorrelation/wrapper.py (5)

1-7: LGTM!

The metadata is correctly formatted and provides useful information.

The code changes are approved.


9-10: LGTM!

The import statement is correct and necessary for the subsequent code.

The code changes are approved.


11-14: LGTM!

The code correctly sets up optional parameters for logging and extra arguments.

The code changes are approved.

Tools
Ruff

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


15-18: LGTM!

The code correctly retrieves required arguments for correlation method and plot type.

The code changes are approved.

Tools
Ruff

16-16: Undefined name snakemake

(F821)


17-17: Undefined name snakemake

(F821)


19-25: LGTM!

The code correctly handles the plot file format and optional output matrix.

The code changes are approved.

Tools
Ruff

20-20: Undefined name snakemake

(F821)


23-23: Undefined name snakemake

(F821)

bio/deeptools/plotcorrelation/wrapper.py Show resolved Hide resolved
@fgvieira fgvieira merged commit a965bd6 into snakemake:master Aug 27, 2024
7 checks passed
dlaehnemann pushed a commit that referenced this pull request Aug 29, 2024
🤖 I have created a release \*beep\* \*boop\*
---
##
[4.3.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v4.2.0...v4.3.0)
(2024-08-28)


### Features

* add support for multiple input file subcommands in seqkit wrapper
(subcommands "common" and "concat")
([#3142](https://www.github.com/snakemake/snakemake-wrappers/issues/3142))
([3b5391f](https://www.github.com/snakemake/snakemake-wrappers/commit/3b5391f619b38334829c06b8bd0526a16e19c732))
* Deeptools multibigwig summary
([#3135](https://www.github.com/snakemake/snakemake-wrappers/issues/3135))
([df7e2bf](https://www.github.com/snakemake/snakemake-wrappers/commit/df7e2bffdd61690e56380bb1b49ca663e58a477c))
* Deeptools plot correlation
([#3137](https://www.github.com/snakemake/snakemake-wrappers/issues/3137))
([a965bd6](https://www.github.com/snakemake/snakemake-wrappers/commit/a965bd62f13bb62722daf08201a00b1f26bef38d))
* Deeptools plot pca
([#3138](https://www.github.com/snakemake/snakemake-wrappers/issues/3138))
([0d9862b](https://www.github.com/snakemake/snakemake-wrappers/commit/0d9862b0f91e74bb90993eb7ecb938dec80d779b))
* Rseqc bamstat
([#3139](https://www.github.com/snakemake/snakemake-wrappers/issues/3139))
([b4267e6](https://www.github.com/snakemake/snakemake-wrappers/commit/b4267e6a0244071a96efc8a91fd6ba982a738cb5))
* Rseqc inner distance
([#3140](https://www.github.com/snakemake/snakemake-wrappers/issues/3140))
([8ca10f3](https://www.github.com/snakemake/snakemake-wrappers/commit/8ca10f3949ca6fb1ed9f9d046c89ca10a7c32c8c))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Sep 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants