-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deeptools plot correlation #3137
feat: Deeptools plot correlation #3137
Conversation
* perf: update bio/bcftools/index/environment.yaml. * perf: update bio/bcftools/index/environment.yaml. * perf: update bio/bcftools/index/environment.yaml.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
* Add autobump action * fix paths * dbg * dbg branch * add checkout * dbg * trigger rerun * entity regex and add label * dbg * Update autobump.yml * Update autobump.yml
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
WalkthroughThe changes introduce several new files related to the DeepTools Plot Correlation tool, including configuration files for Conda environments ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- bio/deeptools/plotcorrelation/environment.linux-64.pin.txt (1 hunks)
- bio/deeptools/plotcorrelation/environment.yaml (1 hunks)
- bio/deeptools/plotcorrelation/meta.yaml (1 hunks)
- bio/deeptools/plotcorrelation/test/Snakefile (1 hunks)
- bio/deeptools/plotcorrelation/wrapper.py (1 hunks)
- test.py (1 hunks)
Files skipped from review due to trivial changes (2)
- bio/deeptools/plotcorrelation/environment.linux-64.pin.txt
- bio/deeptools/plotcorrelation/environment.yaml
Additional context used
Path-based instructions (2)
bio/deeptools/plotcorrelation/wrapper.py (2)
Pattern
**/*.py
: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theself
argument of methods.
Do not suggest type annotation of thecls
argument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturn
statement.
Pattern
**/wrapper.py
: Do not complain about use of undefined variable calledsnakemake
.test.py (1)
Pattern
**/*.py
: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theself
argument of methods.
Do not suggest type annotation of thecls
argument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturn
statement.
Ruff
bio/deeptools/plotcorrelation/wrapper.py
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
16-16: Undefined name
snakemake
(F821)
17-17: Undefined name
snakemake
(F821)
20-20: Undefined name
snakemake
(F821)
23-23: Undefined name
snakemake
(F821)
Additional comments not posted (4)
bio/deeptools/plotcorrelation/test/Snakefile (1)
1-15
: LGTM!The rule is well-defined and follows Snakemake conventions.
The code changes are approved.
bio/deeptools/plotcorrelation/meta.yaml (1)
1-17
: LGTM!The metadata is well-defined and follows the conventions for Snakemake wrappers.
The code changes are approved.
bio/deeptools/plotcorrelation/wrapper.py (1)
1-34
: LGTM!The wrapper script is well-defined and follows the conventions for Snakemake wrappers. The static analysis tool's warnings about undefined
snakemake
references can be ignored assnakemake
is assumed to be defined in this context.The code changes are approved.
Tools
Ruff
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
16-16: Undefined name
snakemake
(F821)
17-17: Undefined name
snakemake
(F821)
20-20: Undefined name
snakemake
(F821)
23-23: Undefined name
snakemake
(F821)
test.py (1)
2844-2855
: LGTM!The function
test_deeptools_plotcorrelation
is correctly implemented. Ensure that it is properly integrated into the test suite.The code changes are approved.
Run the following script to verify the integration of the test function into the test suite:
…is/snakemake-wrappers into deeptools_plot_correlation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- bio/deeptools/plotcorrelation/meta.yaml (1 hunks)
- bio/deeptools/plotcorrelation/test/Snakefile (1 hunks)
- bio/deeptools/plotcorrelation/wrapper.py (1 hunks)
- test.py (1 hunks)
Files skipped from review due to trivial changes (2)
- bio/deeptools/plotcorrelation/meta.yaml
- test.py
Files skipped from review as they are similar to previous changes (1)
- bio/deeptools/plotcorrelation/test/Snakefile
Additional context used
Path-based instructions (1)
bio/deeptools/plotcorrelation/wrapper.py (2)
Pattern
**/*.py
: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theself
argument of methods.
Do not suggest type annotation of thecls
argument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturn
statement.
Pattern
**/wrapper.py
: Do not complain about use of undefined variable calledsnakemake
.
Ruff
bio/deeptools/plotcorrelation/wrapper.py
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
16-16: Undefined name
snakemake
(F821)
17-17: Undefined name
snakemake
(F821)
20-20: Undefined name
snakemake
(F821)
23-23: Undefined name
snakemake
(F821)
Additional comments not posted (5)
bio/deeptools/plotcorrelation/wrapper.py (5)
1-7
: LGTM!The metadata is correctly formatted and provides useful information.
The code changes are approved.
9-10
: LGTM!The import statement is correct and necessary for the subsequent code.
The code changes are approved.
11-14
: LGTM!The code correctly sets up optional parameters for logging and extra arguments.
The code changes are approved.
Tools
Ruff
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
15-18
: LGTM!The code correctly retrieves required arguments for correlation method and plot type.
The code changes are approved.
Tools
Ruff
16-16: Undefined name
snakemake
(F821)
17-17: Undefined name
snakemake
(F821)
19-25
: LGTM!The code correctly handles the plot file format and optional output matrix.
The code changes are approved.
Tools
Ruff
20-20: Undefined name
snakemake
(F821)
23-23: Undefined name
snakemake
(F821)
🤖 I have created a release \*beep\* \*boop\* --- ## [4.3.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v4.2.0...v4.3.0) (2024-08-28) ### Features * add support for multiple input file subcommands in seqkit wrapper (subcommands "common" and "concat") ([#3142](https://www.github.com/snakemake/snakemake-wrappers/issues/3142)) ([3b5391f](https://www.github.com/snakemake/snakemake-wrappers/commit/3b5391f619b38334829c06b8bd0526a16e19c732)) * Deeptools multibigwig summary ([#3135](https://www.github.com/snakemake/snakemake-wrappers/issues/3135)) ([df7e2bf](https://www.github.com/snakemake/snakemake-wrappers/commit/df7e2bffdd61690e56380bb1b49ca663e58a477c)) * Deeptools plot correlation ([#3137](https://www.github.com/snakemake/snakemake-wrappers/issues/3137)) ([a965bd6](https://www.github.com/snakemake/snakemake-wrappers/commit/a965bd62f13bb62722daf08201a00b1f26bef38d)) * Deeptools plot pca ([#3138](https://www.github.com/snakemake/snakemake-wrappers/issues/3138)) ([0d9862b](https://www.github.com/snakemake/snakemake-wrappers/commit/0d9862b0f91e74bb90993eb7ecb938dec80d779b)) * Rseqc bamstat ([#3139](https://www.github.com/snakemake/snakemake-wrappers/issues/3139)) ([b4267e6](https://www.github.com/snakemake/snakemake-wrappers/commit/b4267e6a0244071a96efc8a91fd6ba982a738cb5)) * Rseqc inner distance ([#3140](https://www.github.com/snakemake/snakemake-wrappers/issues/3140)) ([8ca10f3](https://www.github.com/snakemake/snakemake-wrappers/commit/8ca10f3949ca6fb1ed9f9d046c89ca10a7c32c8c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
QC
snakemake-wrappers
.While the contributions guidelines are more extensive, please particularly ensure that:
test.py
was updated to call any added or updated example rules in aSnakefile
input:
andoutput:
file paths in the rules can be chosen arbitrarilyinput:
oroutput:
)tempfile.gettempdir()
points tometa.yaml
contains a link to the documentation of the respective tool or command underurl:
Summary by CodeRabbit
New Features
environment.linux-64.pin.txt
for consistent Conda environment setup on Linux 64-bit.environment.yaml
for configuring Conda environment with DeepTools dependencies.meta.yaml
providing essential metadata for the Deeptools Plot Correlation tool.wrapper.py
to facilitate plotting with customizable parameters.Documentation