Merge pull request #143 from snapdao/fix-tx-fee-zero-issue

Fix Transaction fee is zero issue
snapdao · Dec 22, 2023 · 9a7c7f2 · 9a7c7f2
2 parents 7bad370 + 80f6e25
commit 9a7c7f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/example/src/lib/index.ts b/packages/example/src/lib/index.ts
@@ -167,7 +167,7 @@ const composePsbt = (
 
   const psbt = new Psbt({ network: networkConfig });
 
-  if (!inputs) throw new Error('Utxo selections error please retry');
+  if (!inputs) throw new Error('No suitable UTXOs available for constructing the transaction');
 
   inputs.forEach((each) => {
     const commonFields = {

diff --git a/packages/example/src/lib/psbtValidator.ts b/packages/example/src/lib/psbtValidator.ts
@@ -15,14 +15,14 @@ interface ValidateTxData {
 
 export const validateTx = ({ psbt, utxoAmount, changeAddressPath }: ValidateTxData) => {
   return isChangeAddressBelongsToCurrentAccount(psbt, changeAddressPath) &&
-    !isFeeTooHigh(psbt, utxoAmount) &&
+    isFeeValid(psbt, utxoAmount) &&
     !hasDustOutput(psbt);
 };
 
-const isFeeTooHigh = (psbt: Psbt, utxoAmount: number) => {
+const isFeeValid = (psbt: Psbt, utxoAmount: number) => {
   const outputAmount = psbt.txOutputs.reduce((amount, output) => amount + output.value, 0);
   const fee = utxoAmount - outputAmount;
-  return fee >= MAX_FEE;
+  return fee > 0 && fee < MAX_FEE;
 };
 
 const isChangeAddressBelongsToCurrentAccount = (psbt: Psbt, changeAddressPath: string) => {