feat: add ECDSA signature support #147
Conversation
packages/snap/src/rpc/signMessage.ts
Outdated
| ); | ||
|
|
||
| const btcNetwork = getNetwork(snapNetwork); | ||
| const path = [...pathMap[ScriptType.P2SH_P2WPKH], "0'", '0', '0']; |
There was a problem hiding this comment.
Instead of hardcode the path here, it should be passed in as the parameter.
There was a problem hiding this comment.
Could you please elaborate on this? How do you see it?
There was a problem hiding this comment.
Adding the path as the parameter to the signMessage function.
There was a problem hiding this comment.
I've tried to support the current API of the snap. neither btc_signPsbt and btc_signLNInvoice allow to change the path, should we do it here?
There was a problem hiding this comment.
The PSBT data includes the BIP32 path in the inputs field to indicate which key to use for signing. For signMessage, this information should also be included to specify which key is being used for signing.
There was a problem hiding this comment.
So I'll do then next,
I'm going to remove scriptType from arguments, and will add derivePath argument so users can pass full derivation path, is it ok?
Also I'm going to test the path against request bip32 entropies supported by snap
| network: btcNetwork, | ||
| }).address as string; | ||
|
|
||
| const result = await snap.request({ |
There was a problem hiding this comment.
A warning should be included, if the message is not an hummable readable string, like a hex string.
There was a problem hiding this comment.
i've included warning for any message, the same way metamask does.
|
appbak3r
force-pushed
the
feat/ecdsa-signature
branch
from
db783c2
to
a299f73
Compare
|
@aaronisme updated |
This PR introduces a new RPC method to the Bitcoin Snap that allows for the signing of messages.
This feature enhances the BTC Snap by providing users with the ability to sign messages directly from the Snap, improving functionality and user control.
The added tests ensure that the feature is reliable and behaves as expected in various conditions.