Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network-3.0.0.0 #65

Merged
merged 3 commits into from
Jan 28, 2019

Conversation

naushadh
Copy link
Contributor

@naushadh naushadh commented Jan 20, 2019

Changes

CI

$ (cd io-streams-* && cabal check)
Warning: These warnings may cause trouble when distributing the package:
Warning: 'ghc-options/ghc-prof-options: -fprof*' profiling flags are typically
not appropriate for a distributed library package. These flags are useful to
profile this package, but when profiling other packages that use this one
these flags clutter the profile output with excessive detail. If you think
other packages really want to see cost centres from this package then use
'-fprof-auto-exported' which puts cost centres only on exported functions.
Alternatively, if you want to use this, make it conditional based on a Cabal
configuration flag (with 'manual: True' and 'default: False') and enable that
flag during development.
Warning: 'ghc-options/ghc-prof-options: -fprof*' profiling flags are typically
not appropriate for a distributed library package. These flags are useful to
profile this package, but when profiling other packages that use this one
these flags clutter the profile output with excessive detail. If you think
other packages really want to see cost centres from this package then use
'-fprof-auto-exported' which puts cost centres only on exported functions.
Alternatively, if you want to use this, make it conditional based on a Cabal
configuration flag (with 'manual: True' and 'default: False') and enable that
flag during development.
The command "(cd io-streams-* && cabal check)" exited with 1.

- Fixes:  commercialhaskell/stackage#4312
- Address some compiler warnings in tests (IO with unused result).
- Updated deprecated/removed upstream API usage in tests with conditional blocks to support older test matrices.
Though the project does not have a stack.yaml file, contributors may use it for their own development and this makes it slightly easier.
@hvr hvr changed the title Relax bound network Add support for network-3.0.0.0 Jan 21, 2019
@hvr
Copy link
Member

hvr commented Jan 21, 2019

Renamed cause this PR is a lot more than merely relaxing a version bound... ;-)

@@ -1,3 +1,6 @@
# Version 1.5.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By PVP this has to be a minor version bump, but I'll fix it post-facto

@gregorycollins gregorycollins merged commit 1451ac7 into snapframework:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network 3.0.0.0
3 participants