-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fpm-alpine image and Docker secrets support #9313
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
This was referenced Mar 18, 2021
snipe
pushed a commit
that referenced
this issue
Apr 21, 2021
…rt (#9331) * Add docker secret support * Add docker secret support to selected environment variables below: - APP_KEY_FILE -> APP_KEY; - DB_HOST_FILE -> DB_HOST; - DB_PORT_FILE -> DB_PORT; - DB_DATABASE_FILE -> DB_DATABASE; - DB_USERNAME_FILE -> DB_USERNAME; - DB_PASSWORD_FILE -> DB_PASSWORD; - REDIS_HOST_FILE -> REDIS_HOST; - REDIS_PASSWORD_FILE -> REDIS_PASSWORD; - REDIS_PORT_FILE -> REDIS_PORT; - MAIL_HOST_FILE -> MAIL_HOST; - MAIL_PORT_FILE -> MAIL_PORT; - MAIL_USERNAME_FILE -> MAIL_USERNAME; - MAIL_PASSWORD_FILE -> MAIL_PASSWORD; * Add env file for docker secrets * Added #9313: add new fpm-image using docker secrets * Fix broken symlinks * Add docker secrets support using shell script * Remove old docker config php files
2 tasks
This was referenced Sep 20, 2022
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello everyone,
Snipe-IT is great software, thank you all for your hard work!
I tried to create a production-ready php-fpm-alpine image following the best practices of wordpress and php-fpm official docker images. (does not make it perfect. Feel free to point anything wrong!)
Could this be useful for a PR?
I added easy-to-use support for development, but it’s worth saying that I haven’t tested this image extensively for this purpose. I also added support for docker secrets for some variables
APP_KEY
,DB_HOST
,DB_PORT
,DB_DATABASE
,DB_USERNAME
,DB_PASSWORD
,MAIL_HOST, MAIL_PORT
,MAIL_USERNAME
andMAIL_PASSWORD
, as I am going to deploy snipe-it in a docker swarm environment and the image is already using the scripts.Also, there are some custom
ARGs
that can facilitate general use and image maintenance.I read the contribution guidelines and realized that I need an open issue to be referenced in commits message.
Please bear with me because I have never contributed to any open source project yet.
What do you think? Should I proceed with this?
Below is the
v5.1.3-fpm-alpine
image:Below is a
docker-compose.yml
file using docker secrets. Bear in mind that I used the fpm-alpine image above as base to build my nginx + snipeit-fpm-alpine image:The text was updated successfully, but these errors were encountered: