Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes BadMethodCallException Call to undefined method App\Models\Asset::unaccepted() for master [ch-17636] #10758

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Mar 2, 2022

Description

Same as #10757, but as the method getAssetsNotAcceptedYet() is not longer used, I just delete it.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@inietov inietov requested review from uberbrady and snipe March 2, 2022 01:01
@inietov inietov changed the title Fixes BadMethodCallException Call to undefined method App\Models\Asset::unaccepted() [ch-17636] Fixes BadMethodCallException Call to undefined method App\Models\Asset::unaccepted() for master [ch-17636] Mar 3, 2022
@inietov
Copy link
Collaborator Author

inietov commented Mar 8, 2022

Just kind of argumenting in favor of this PR: in master branch getAssetsNotAcceptedYet() is used by the function exportAssetAcceptanceReport(). But in develop it uses the CheckoutAcceptance model, that's why I remove the chunk completely here. :)

@snipe snipe merged commit b04cf20 into snipe:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants