Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer suppliers and manufacturers UI #11313

Merged
merged 6 commits into from
Jun 15, 2022
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 14, 2022

This, similar to the recent Locations improvements, should add counts to the top of the suppliers and manufacturers tabs and move the stacked tables to tabbed interfaces.

One thing to note - if you have the option in Admin Settings to NOT show archived assets in lists, the number on the badge in the tab may not match the number of assets displayed in the table below, since it won't show the archived assets.

This also adds supplier_id and asset_maintenance_type to the asset maintenance API endpoint as filters, and fixes an issue where we were not using translation strings for some of the tabs previously - and it also improves the mobile UI the same way we did with the Person UI, using large icons on the tabs instead of long text.

Desktop:
Screen Shot 2022-06-14 at 4 32 32 PM

Mobile:
Screen Shot 2022-06-14 at 4 32 23 PM

Old supplier:
Screen Shot 2022-06-14 at 4 54 58 PM

New supplier:
Screen Shot 2022-06-14 at 4 55 15 PM

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Loving all of these new improvements :)

@snipe snipe merged commit 693043e into develop Jun 15, 2022
@snipe snipe deleted the fixes/nicer_suppliers_mfgs_ui branch June 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants