Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added number_format() to tab badges #11326

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Added number_format() to tab badges #11326

merged 1 commit into from
Jun 16, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 15, 2022

Eventually we'll want to convert these into localized number displays (2.000,00, etc), but this is better than nothing :)

@snipe snipe requested a review from uberbrady June 15, 2022 22:01
uberbrady
uberbrady approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll accept this, but I'd much rather have no punctuation at all than have the wrong internationalized format. People get awful touchy about that stuff. I can help build a PHP helper we can use, if that helps? Regardless, I accept it :)

@snipe snipe merged commit cabef8f into develop Jun 16, 2022
@snipe snipe deleted the features/added_number_format_to_tab_badges branch June 22, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady uberbrady approved these changes

Assignees
No one assigned
Labels
backend frontend legal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snipe @uberbrady