Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds validation to custom fields' default values #11370

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jun 23, 2022

Description

When creating/editing models, if we want to add default values to the fieldsets the form doesn't check the validation rules of them. So we can save whatever value we want as default value even when we set the format to the custom field.

This changes tries to fix that and also adds some control dates so it's less probable the user sets the date format incorrectly.

Fixes #11230

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@inietov inietov requested review from uberbrady and snipe June 23, 2022 02:06
@inietov inietov changed the base branch from master to develop June 23, 2022 02:07
@inietov inietov marked this pull request as ready for review June 23, 2022 03:24
@snipe snipe merged commit 8c85d7b into snipe:develop Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants