-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes check for archived setting on counts #11382
Conversation
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I think putting that in a Scope is very clever. That's a lot smarter than the way I think I would've done it. Great work!
To your second paragraph. How about adding an option to the. ENV file. Maybe AddArchiveToCount = true or false. Leave it up to the admin whether to count archived items towards the total inventory. Thanks for the change. Much appreciated. |
If you’ve already said you don’t want to see archived assets in your lists, why would you want them in your totals counts? It would just make the numbers inconsistent, no? |
Personally, I don't want the archived items to count towards the total inventory count. I am just providing a possible solution to your second comment, which is to allow the admin to decide whether or not they wish to show the archived items as part of the total inventory count by simply making a change to the. ENV file.
Thank you so
Joe
Get BlueMail for Android
…On Jul 1, 2022, 11:23 AM, at 11:23 AM, snipe ***@***.***> wrote:
If you’ve already said you don’t want to see archived assets in your
lists, why would you want them in your totals counts? It would just
make the numbers inconsistent, no?
--
Reply to this email directly or view it on GitHub:
#11382 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
In a previous PR, I had mentioned that we'd need to scope the counts on the tabs to consider if archived assets should be shown in the list, because there is a perceptual confusion, since the number on the tab and the number displayed in the list might not be the same if the admin has elected to hide archived assets from lists. This should handle that problem.
There is still the existential confusion of people not knowing (or remembering) that that option was checked and seeing fewer assets than they expect, but I'm not sure there's a way around that, since people want that option.