Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes check for archived setting on counts #11382

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 23, 2022

In a previous PR, I had mentioned that we'd need to scope the counts on the tabs to consider if archived assets should be shown in the list, because there is a perceptual confusion, since the number on the tab and the number displayed in the list might not be the same if the admin has elected to hide archived assets from lists. This should handle that problem.

There is still the existential confusion of people not knowing (or remembering) that that option was checked and seeing fewer assets than they expect, but I'm not sure there's a way around that, since people want that option.

@snipe snipe requested review from uberbrady and inietov June 23, 2022 23:03
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I think putting that in a Scope is very clever. That's a lot smarter than the way I think I would've done it. Great work!

@snipe snipe merged commit 670a46e into develop Jun 23, 2022
@snipe snipe deleted the fixes/check_for_archived_setting_on_counts branch June 23, 2022 23:13
@jmartins1
Copy link

jmartins1 commented Jul 1, 2022

To your second paragraph. How about adding an option to the. ENV file. Maybe AddArchiveToCount = true or false. Leave it up to the admin whether to count archived items towards the total inventory.

Thanks for the change. Much appreciated.

@snipe
Copy link
Owner Author

snipe commented Jul 1, 2022

If you’ve already said you don’t want to see archived assets in your lists, why would you want them in your totals counts? It would just make the numbers inconsistent, no?

@jmartins1
Copy link

jmartins1 commented Jul 1, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants