Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to default blue #11386

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Small fixes to default blue #11386

merged 5 commits into from
Jun 24, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 24, 2022

Somewhere in the massive reworking of the skins, some colors got a little odd on the default blue skin. It's a tiny thing, but it's been bugging me.

While normally we want link colors to be different based on whether they are a link, a hovered link, or a visited link, the nav options on the settings page doesn't really adhere to those rules (and I think it looks weird when they do, especially with the visited link color we were using, which was a lot colder than the warmer blue we use in the header.)

Old:

Screen Shot 2022-06-23 at 6 12 11 PM

New:

Screen Shot 2022-06-23 at 6 21 08 PM

I also fixed an issue where text on btn-default and label-default was blue when it should have been a dark grey.

Old:

Screen Shot 2022-06-23 at 6 21 58 PM

New:

Screen Shot 2022-06-23 at 6 22 06 PM

This basically restores the old behavior.

@snipe snipe merged commit 590630e into develop Jun 24, 2022
@snipe snipe deleted the fixes/default_skin_settings_colors branch June 24, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant