Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom field transliteration #11404

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 27, 2022

We're seeing an issue in certain cases where PHP has been upgraded that can result in a 500 error when adding/updating an asset, because what we're expecting that column to be named and what it's actually named are now different, due to (what we think is) a small change in the PHP transliteration library.

This PR updates the existing snipeit:regenerate-fieldnames console command to check both the column name on the assets table and also the value in the db_column field in the custom_fields table.

You can tell if this script will fix your issue by going to the Custom Fields page in your UI, disclosing the "DB Column" column using the column selector, and then looking for warning text.

Screen Shot 2022-06-27 at 2 00 32 PM

Output of the console log looks like this:

Screen Shot 2022-06-27 at 1 57 06 PM

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks even better - nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants