Add a new --filter option to Artisan ldap-sync command
#11408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows along with the BaseDN option in our
snipeit:ldap-syncartisan command to also add a Filter option as well.Similarl to the BaseDN option, it will skip the per-OU LDAP sync if it is specified. The parameter just becomes an optional argument when the LDAP sync is performed; overriding the default LDAP filter that's used in other LDAP sync commands.
This solves at least one problem that one customer of ours has had recently, and will probably help out a few more. It also doesn't make too many huge changes in our code, so it seems relatively safe?