Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SCIM be more tolerant of missing fields #11430

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

uberbrady
Copy link
Collaborator

Our SCIM library documents that you can set a 'thing' to be an array or nullable, and then a sub-thing as required.

e.g. in this example -

{ "phone": [ {"value": "123-456-7890"} ] }

Phone isn't required, but if you do give us a phone, it better have a value.

But this was blowing up on MS's SCIM implementation for some reason I still don't fully understand.

So I removed the required attribute on the 'sub-thing' when I could. The one user who I couldn't get to synchronize was finally able to synchronize when I made this change.

I also still had some yucky Log statements that aren't particularly useful anymore, and so instead of setting those to debug I just removed them.

@uberbrady uberbrady requested a review from snipe as a code owner June 29, 2022 21:55
@snipe snipe merged commit 02459aa into snipe:develop Jun 29, 2022
@snipe
Copy link
Owner

snipe commented Jun 29, 2022

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants