Make SCIM be more tolerant of missing fields #11430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our SCIM library documents that you can set a 'thing' to be an array or nullable, and then a sub-thing as required.
e.g. in this example -
Phone isn't required, but if you do give us a phone, it better have a value.
But this was blowing up on MS's SCIM implementation for some reason I still don't fully understand.
So I removed the required attribute on the 'sub-thing' when I could. The one user who I couldn't get to synchronize was finally able to synchronize when I made this change.
I also still had some yucky Log statements that aren't particularly useful anymore, and so instead of setting those to debug I just removed them.