Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a checkbox to exclude archived assets from custom reports #11488

Conversation

Godmartinz
Copy link
Collaborator

Description

Adds a checkbox to exclude archived assets from custom reports

Fixes # SC-19107

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe July 12, 2022 16:47
@Godmartinz
Copy link
Collaborator Author

->notArchived() is being used now

@snipe
Copy link
Owner

snipe commented Jul 12, 2022

Great! Can you pull the commented line out? Once that's done, it looks good to me.

@snipe snipe merged commit 0ccd7e0 into snipe:develop Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants