Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded our fork of laravel-scim-server to better support scim creates #11528

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

uberbrady
Copy link
Collaborator

Our SCIM support was breaking in Azure when a pre-existing user existed in Snipe-IT, and Azure's SCIM service also tried to simultaneously create one. The error shows up weird, as a strange redirect to the login page, because a weird exception was thrown and Laravel didn't quite know how to handle it, so it assumed it was an authentication problem - it wasn't, it was actually a model-level validation problem.

I've upgraded our fork of laravel-scim-server, and this change to the composer.lock makes sure we pull the correct version down when people do composer installs. I'll need to do some testing to make 100% sure that the new changes will get pulled down when the composer.lock file gets changed. If not, I'll have to go another way to make sure that we're always pulling the latest.

Once I've finished the testing, I'll switch this PR out of WIP status.

@uberbrady
Copy link
Collaborator Author

Okay, I've tested by flipping back and forth from the develop branch to this branch and running composer install - when I'm on develop, the line that I fixed is not in the ./vendors directory, and when I switch to my branch, the line that I fixed is in the ./vendors directory. So it's working as expected.

@uberbrady uberbrady marked this pull request as ready for review July 18, 2022 22:19
@uberbrady uberbrady requested a review from snipe as a code owner July 18, 2022 22:19
@snipe snipe merged commit e72c4f9 into snipe:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants