Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 404 fixed on submitting without mandatory field #11601

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

vickyjaura183
Copy link

Description

NOTE: this is another PR requested because I created PR with 'master' earlier. reference pull: #11557

The issue was related to Bulk Checkout page. If we leave mandatory field blank, it was giving 404 error.
Step 1: Click on 'Bulk Checkout' from left sidebar under 'Asset' tab.
Step 2: Directly click on 'Checkout' button without filling mandatory field 'User' if 'User' is selected in 'Checkout To'.
Step 3: You will be displayed 404 error. ( https://tinyurl.com/282vnoeo )

Fixes # I have fixed of 404 error on Bulk checkout page by giving setting the AssetCheckoutRequest instead of Request instance in BulkAssetsController.php in function storeCheckout. Doing this it will display prorper error as attached in screenshot (https://www.awesomescreenshot.com/image/30575927?key=09b321f39b00222a34bbb8295bb42783 )

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ # ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have tested this manually. steps are below:
Step 1: Click on 'Bulk Checkout' from left sidebar under 'Asset' tab.
Step 2: Directly click on 'Checkout' button without filling mandatory field 'User' if 'User' is selected in 'Checkout To'.
Step 3: You will be able to see the proper error as attached in screenshot or link. ( https://www.awesomescreenshot.com/image/30575927?key=09b321f39b00222a34bbb8295bb42783 )

Test Configuration:
PHP version: 8.1
MySQL version: 8
Webserver version : Apache
OS version : Ubuntu 20

Checklist:

[ # ] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
[ # ] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
[ # ] My code follows the style guidelines of this project
[ # ] I have performed a self-review of my own code
[ # ] I have commented my code, particularly in hard-to-understand areas
[ # ] I have made corresponding changes to the documentation
[ # ] My changes generate no new warnings
[ # ] I have added tests that prove my fix is effective or that my feature works
[ # ] New and existing unit tests pass locally with my changes

@snipe snipe changed the title Error 404 fixed on sumitting witout mandtory field Error 404 fixed on submitting without mandatory field Aug 3, 2022
@snipe snipe merged commit 1b657ee into snipe:develop Aug 3, 2022
@welcome
Copy link

welcome bot commented Aug 3, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@snipe
Copy link
Owner

snipe commented Aug 3, 2022

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants