Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Monthly depreciation calculation if EOL is blank #11642

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

Godmartinz
Copy link
Collaborator

Description

If an EOL (end of life) date is missing from Asset models the monthly depreciation will now still be calculated with the months stated in the depreciation model attached to said Asset model for depreciation reports.

Without EOLs:
image

With EOLs:
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@snipe
Copy link
Owner

snipe commented Aug 9, 2022

This looks great, thank you!

@snipe snipe merged commit a834ac6 into snipe:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants