Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6899 Docker container's php configuration isn't congruent with snipe-it uploads setting size. #11662

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

octobunny
Copy link
Contributor

@octobunny octobunny commented Aug 11, 2022

Description

For docker deployments.

The PHP_UPLOAD_LIMIT environmental variable only adjusts upload_max_size in php.ini.

Since the post_max_size is still left at 8MB, file uploads will remain capped at 8MB even if the user sets the PHP_UPLOAD_LIMIT to something greater.

This adds an additional line to set the post_max_size to as well, enabling the upload maximum to be set to greater than 8MB.

Fixed #6899: Docker container's php configuration isn't congruent with snipe-it uploads setting size.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added to startup.sh in personal deployment. Verified changes in help text and uploading large PDFs (manuals) to assets.

Test Configuration:

  • Docker (Swarm Mode): 20.10.12
  • MariaDB (Galera) version: 10.4.25
  • Docker Image: 6.0.8
    • PHP version: 7.4
    • Webserver version: Apache 2.4.41
    • OS version: Ubuntu 20.04

Must change post_max_size in addition to upload_max_filesize to increase total upload size to greater than 8MB.
@welcome
Copy link

welcome bot commented Aug 11, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe merged commit 1763bbf into snipe:develop Aug 14, 2022
@welcome
Copy link

welcome bot commented Aug 14, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants