Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare DB_PORT in all .env files #11669

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Declare DB_PORT in all .env files #11669

merged 1 commit into from
Aug 22, 2022

Conversation

kylegordon
Copy link
Contributor

Description

Simple declaration of DB_PORT in all .env files. This resolves the 500 error that is generated when attempting to use both the web GUI backup and PHP artisan snipeit:backup

The error was generating the following

[2022-08-12 14:53:07] production.ERROR: Argument 1 passed to Spatie\DbDumper\DbDumper::setPort() must be of the type int, string given, called in /var/www/html/vendor/spatie/laravel-backup/src/Tasks/Backup/DbDumperFactory.php on line 51 {"userId":331,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Argument 1 passed to Spatie\\DbDumper\\DbDumper::setPort() must be of the type int, string given, called in /var/www/html/vendor/spatie/laravel-backup/src/Tasks/Backup/DbDumperFactory.php on line 51 at /var/www/html/vendor/spatie/db-dumper/src/DbDumper.php:120)
[stacktrace]

Fixes #7353

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested and confirmed in my own Docker instance of snipeit:latest (v5.4.4 build 6829 (gfd71b4848))

  • Test before change
  • Test after provision of DB_PORT=3306

Test Configuration:

  • PHP version:7.4.3
  • MySQL version: mariadb:10.8.2
  • OS version: dockerised, in Debian 10

Checklist:

@kylegordon kylegordon requested a review from snipe as a code owner August 12, 2022 14:15
@welcome
Copy link

welcome bot commented Aug 12, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe changed the base branch from master to develop August 22, 2022 23:20
@snipe snipe merged commit d649c65 into snipe:develop Aug 22, 2022
@welcome
Copy link

welcome bot commented Aug 22, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service reported 500 error
2 participants