Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Translation String: wrong key at request canceled message #11703

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fixed Translation String: wrong key at request canceled message #11703

merged 1 commit into from
Aug 22, 2022

Conversation

julian-piehl
Copy link
Contributor

Description

The translation key misses an "ed" at the end.

@snipe
Copy link
Owner

snipe commented Aug 19, 2022

Thanks for this! We always appreciate folks taking the time to help out with translations. We don't currently manage translations through Pull Requests however, only through the CrowdIn platform. You can find more info on that here: https://snipe-it.readme.io/docs/translations

Snipe-IT Documentation
Traduci! 翻訳!Oversette! Traduire! 번역하기! แปล! ¡Traducir! Przetłumacz! Übersetzen!

@snipe snipe closed this Aug 19, 2022
@julian-piehl
Copy link
Contributor Author

julian-piehl commented Aug 19, 2022

Thanks for this! We always appreciate folks taking the time to help out with translations. We don't currently manage translations through Pull Requests however, only through the CrowdIn platform. You can find more info on that here: https://snipe-it.readme.io/docs/translations

I think you understand me wrong @snipe.
Not the translation is wrong. The translation key is wrong

trans('key');

At one point the key admin/hardware/message.requests.cancel is used, but the right key is admin/hardware/message.requests.canceled

@snipe snipe reopened this Aug 19, 2022
@snipe
Copy link
Owner

snipe commented Aug 19, 2022

Got it - thanks for the clarification!

Can you please re-target this PR to point to the develop branch, per our Contributing documentation?

You don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.

mhuxq

Thanks!

@julian-piehl julian-piehl changed the base branch from master to develop August 19, 2022 17:25
@julian-piehl julian-piehl closed this by deleting the head repository Aug 19, 2022
@julian-piehl
Copy link
Contributor Author

Done :D

@julian-piehl julian-piehl reopened this Aug 19, 2022
@snipe snipe merged commit 906a36d into snipe:develop Aug 22, 2022
@welcome
Copy link

welcome bot commented Aug 22, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@snipe
Copy link
Owner

snipe commented Aug 22, 2022

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants