Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11769: PAT Test hardcoded text #11771

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

rnelsonee
Copy link

@rnelsonee rnelsonee commented Sep 1, 2022

Description

Changed a hard-coded text to use a translation, just like all other items in the list. This is to allow proper translation and localization of this item ("PAT Test")

Fixes #11769

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested by changing the translations is the following files:
resources/lang/en/admin/asset_maintenances/general.php
resources/lang/es-MX/admin/asset_maintenances/general.php

and changing the 'pat_test' => 'PAT Test' to 'Other test' for en (English) and 'PAT prueba' for es-MX (Spanish, Mexico)

And then you can go to the Maintenance tab on an asset, in English or in Spanish, and Create New and see the new translation as an option ("Other test" or "PAT prueba" vs "PAT Test")

Test Configuration:

  • PHP version: 8.1.9
    Apache
  • OS version Ubuntu

Checklist:

@snipe snipe merged commit ac4f919 into snipe:develop Sep 15, 2022
@welcome
Copy link

welcome bot commented Sep 15, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@snipe
Copy link
Owner

snipe commented Sep 15, 2022

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants