Fixed Mini quantity field values are not importing into Snipe-IT

[inietov]

Description

The CSV importer for Consumables and Accessories doesn't include the min_amt field, so this PR adds it.

Fixes freshdesk #30628 and shortcut [sc-19520]

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.23
• Webserver version: nginx/1.19.8
• OS version: Debian 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[swartzfeger]

inietov did you experience item number also not importing via csv? I may need to look at your work to fix this issue I'm having :)

[inietov]

Wasn't aware, just let me test that. Item number is a Consumables' field, right?

[inietov]

Just tested in my local and it's working:

Probably you gonna need to open your own issue with more details so we can help you.

[swartzfeger]

Just tested in my local and it's working:

Probably you gonna need to open your own issue with more details so we can help you.

Hmm, I'm stumped -- I'm getting neither model no or item no in consumables... I also wasn't getting min_qty like you so I thought maybe they were related. I will look into this more deeply (I'm a complete beginner but I find this very fun!)

[inietov]

@swartzfeger Always great to have new people involved! Take a look at your logs, and relevant code is in app/Importer/ConsumableImporter.php, but I just check and both fields are set from the CSV:

As I said before, keep us informed about your findings in your own issue, if I can help you I do that gladly :)

[swartzfeger]

@swartzfeger Always great to have new people involved! Take a look at your logs, and relevant code is in app/Importer/ConsumableImporter.php, but I just check and both fields are set from the CSV:

As I said before, keep us informed about your findings in your own issue, if I can help you I do that gladly :)

I haven't touched php or mysql since 2004 (php3?) so it's been a long time :) But I'm having fun learning again and would love to contribute.

My importer has
$this->item['item_no'] = $this->findCsvMatch($row, 'item_number');

Which is why I'm confused. During the setup (when you reference the head field to the import field), I can see the item number under sample value. But after import (no errors reported), the Item No. column is empty :/

FWIW, I added

$this->item['order_number'] = $this->findCsvMatch($row, 'order_number');

and I referenced my item_no csv to the order_number field and it imports just fine. This workaround is ok for now but not ideal, as the order number is technically not the item number.