Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 500 error if uploaded file is missing from asset view #11836

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Fixed 500 error if uploaded file is missing from asset view #11836

merged 2 commits into from
Sep 15, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 15, 2022 •
edited
Loading

Turns out, using an @ doesn't suppress Storage:: exceptions, so I've updated this to check if the file exists, versus throwing a 500.

Screen Shot 2022-09-15 at 4 14 15 PM

uberbrady
uberbrady approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Another solid catch.

@snipe snipe merged commit 0f777b3 into develop Sep 15, 2022
@snipe snipe deleted the fixes/500_if_image_is_missing branch September 15, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady uberbrady approved these changes

Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snipe @uberbrady