Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Purchase date "readonly" value makes purchase date unable to be nulled in update form [sc-19540] #11856

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Sep 20, 2022

Description

When I make the Purchase Date input as read only, the capacity to delete the content of that input was lost. As the Purchase Date is an optional field, this was effectively an introduced bug.

This PR takes care of that error adding a link that allows to delete the date in the input and save the asset if for some reason we need to delete that value. For some reason my cursor stays as an i-beam instead of changing to a hand (link), but I don't think that was an issue.

Fixes shortcut 19540 [sc-19540]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1.10
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - if you want to fix the cursor issue, take a look at the CSS property cursor: pointer and that might solve your issue. You can apply it directly to the <a

@snipe snipe merged commit 091ef62 into snipe:develop Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants