Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mobile views and clickability of sidebar menu #11916

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

Godmartinz
Copy link
Collaborator

Description

Positions the side-bar out of conflict with the nav-bar allowing the sidebar buttons to be clickable in all responsive sizes of the app.
Screen Shot 2022-10-04 at 12 07 12 PM

Fixes #11868

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@snipe snipe merged commit c70c8ce into snipe:develop Oct 5, 2022
@snipe
Copy link
Owner

snipe commented Oct 5, 2022

This is creating a weird space above the dashboard icon with even the closed menu tho.

Screen Shot 2022-10-04 at 8 14 42 PM

@snipe snipe changed the title fixes mobile views and clickability of sidebar menu Fixes mobile views and clickability of sidebar menu Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants