Added autoglossonyms for locales and translations for countries #11924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <[email protected]>
uberbrady
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
This looks great - I hadn't even thought of the fact that, in each language, the name of its own language as well as others should probably be localized to that language.
For example, in Portuguese, the language "Portuguese" will be "Português" and "English" will be "Inglês"
It's unfortunately a lot more translation strings for our translators to deal with, but so long as they at least fall back to the English (which I believe they will), we should be okay.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the names of the languages and countries into their own localization file, so that they can be translated into their respective languages.
"Deutsch" is the autoglossonym of German and "Nederlands" is the autoglossonym of Dutch. for example. This will let people translate country names and languages into their own languages instead of being hard-coded as english.
I also added a few additional accessibility elements to the select list.