Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the calc of months and fixes typo of the word depreciation #11986

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

Godmartinz
Copy link
Collaborator

Description

Fixes a typo of the word depreciation and fixes the conversion of years to months for depreciation calculation.

Fixes # FD31357

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz changed the title gets the proper amount of months and fixes typo of the word depreciation Fixes the calc of months and fixes typo of the word depreciation Oct 17, 2022
@snipe snipe requested a review from uberbrady October 17, 2022 18:19
@Godmartinz
Copy link
Collaborator Author

I swear this was handled this way before, but not sure what happened to it.

@snipe snipe merged commit 1ec3039 into snipe:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants