Fixed: Okta LDAP Manager Attribute - Better handle LDAP Manager settings #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also the typo-fixes and whitespace fixes are due to our evil dictator demanding them of me. Please send help. I'm trapped in a tiny, windowless room! |
|
Also the script at least runs - so that's something (I just ran it against our test AD instance). So, like, no syntax errors or seriously stupid stuff. |
snipe
reviewed
Oct 20, 2022
app/Console/Commands/LdapSync.php
Outdated
| @@ -233,7 +247,6 @@ public function handle() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please pull this extra line break
|
This looks great, and at worst, it seems non-breaking. Thanks so much - I know how much time it took for you to troubleshoot this issue. |
snipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer had a problem where their Okta configuration was failing to synchronize. It turns out they had an "LDAP Manager" attribute set to
managerid. It turns out that Okta doesn't return a fully-qualified DN for their Managers - just an 'email-address-looking-like' username.Instead of janking up our Manager lookup code, I've just thrown a
try/catcharound it, and set it to 'fall-back' to do a straight lookup on whatever that Manager was against ourusernamefield. I think this will work when people have their Okta configured to use 'email-address-esque' usernames, but it will probably fail with 'short usernames'.But, all that being said, this is at least slightly better than what we were doing before. And if the LDAP lookup causes an exception, it won't abort the entire synchronization process. That's at least something.