Added cache manager lookups in LDAP for performance boost #12006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
changed the title
|
This looks solid to me, thanks @uberbrady! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you work under the assumption that generally a manager manages multiple people, then we should cache the manager lookups and that should speed up the operation of the sync script.
I noticed for one customer that their sync with the manager lookup made sync slow down from 2 minutes to around 10 or so - so this fix will hopefully add back a little bit of that lost performance.
I tested this by running it against our development LDAP server and it seemed to work ok? Definitely seemed at least a touch faster (though we don't have many managers set in there).