Fixed #9949 Unable to update field values for custom field without changing the name

[inietov]

Description

When updating Custom Fields via the API the Validator was using the rules from the CustomField model. Which works well when creating a new CustomField ie: Name is required because we cannot create a CustomField without one, and cannot already be taken on another CustomField. But when we are updating one this rule is causing that we need to pass the name field to the PUT method and if passed we cannot pass the same name that field already has.

I'm creating a custom validator, because the PUT method has the name and element fields as required, but we can pass the same existent values if we don't want to change the name, for example. My problem is the PATCH method, because that can change whatever it passes. So I don't know how to 'detect' when it's a PATCH so I can remove those validation rules...

Fixes #9949

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.23
• Webserver version: nginx/1.19.8
• OS version: Debian 10

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[uberbrady]

Good catch! Yes, that looks like a bug - we shouldn't be validating against the field's validation rules, we should be validating against the rules for Custom Fields themselves.

That being said, If we're going to put these validation rules on a Custom Field (and I think we should!) then we should put them into the protected $rules element within the Custom Field model itself, and be prepared for the save() method to fail (when validation doesn't pass). One thing we can also protect against here is if a user tries to have two custom fields with the same name - which we should try to prevent.

If you can do something along those lines (and I'll be happy to help!) I think that will be the best solution to the problem that works the best way with what we are already doing in most other places.

Thanks!