Fix HTTP AssetTransformer to generate an empty object for missing custom fields

[fernando-almeida]

Description

If an asset does not have any associated custom fields the application is returning an empty array instead of an empty object defrauding output type expectation for the property.

Fixes # (issue)

#9700

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Test Configuration:

• PHP version:
• MySQL version
• Webserver version
• OS version

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[welcome]

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

• Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
• Added #<issue number>: add checkout functionality to assets
• Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

• Document any user-facing changes you've made.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[what-the-diff]

• Change the type of custom_fields from array to object
• Add a new line comment "HACK" in front of the code that was changed

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[snipe]

Hm, I'm actually seeing some issues with this if the asset is deleted. I'll try to fix.

[fernando-almeida]

Ok, thanks.

…

On Tue, Nov 15, 2022, 17:00 snipe ***@***.***> wrote: Hm, I'm actually seeing some issues with this if the asset is deleted. I'll try to fix. — Reply to this email directly, view it on GitHub <#12106 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPCNNTHG7VMLJHFBFE5OATWIO6UVANCNFSM6AAAAAASACXFB4> . You are receiving this because you authored the thread.ok, Message ID: ***@***.***>

[snipe]

No problem :) Was just a missing slash to provide namespace context :)