Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace error suppression with better logic #12121

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Replace error suppression with better logic #12121

merged 1 commit into from
Nov 15, 2022

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 15, 2022

This just removes the (lazy) @ symbol and uses exists() logic instead.

@snipe snipe merged commit 5103f28 into develop Nov 15, 2022
@what-the-diff
Copy link

what-the-diff bot commented Nov 15, 2022

  • The file size is now displayed as 0 bytes if the file does not exist.
  • If a note exists, it will be shown in parentheses after the filename on line 1304 (in bold).

@snipe snipe deleted the fixes/safer_file_existance_checking_for_model_files branch November 19, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snipe