Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11699 and #12065 Email issues #12125

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Nov 16, 2022

Description

Fixes a couple of settings. The email logo is not respected in forgotten password emails and if user have links deactivated email notifications still have the link active to click on.

Fixes #11699 and #12065

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Nov 16, 2022

  • Added a new setting to the admin settings page called "Show URL in Emails"
  • If this is set, then we will show the url in emails (the default behavior)
  • If it's not set, then we won't show any URLs at all (for security reasons). This means that if you click on an email link from Snipe-IT and are logged out of your session for some reason, you'll be redirected back to login instead of being taken directly into whatever resource was linked in the email itself.

@snipe snipe merged commit 6113afe into snipe:develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants