Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11980 Submit button deactivated in Users' Bulk Checkin if no status selected #12167

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Nov 23, 2022

Description

Someone was annoyed because in the users bulk-checkin view, if you didn't selected one status for all the assets that got checked in, the system came back into the users list with an error and no users selection is preserved.

I can see how, although little, this change is an enhancement to the current workflow if for some reason you didn't pay attention to the status and just click submit. This PR disables the submit button until the selected status is a valid one.

Fixes #11980

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe snipe merged commit 305df42 into snipe:develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants