-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #14426: Makes all Manufacturer links dynamic, not just warranty lookup #14470
Conversation
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Snyk has created this PR to upgrade webpack from 5.90.1 to 5.90.2. See this package in npm: https://www.npmjs.com/package/webpack See this project in Snyk: https://app.snyk.io/org/snipe/project/3d53e1dd-b8bf-46b5-ba61-18ce26933166?utm_source=github&utm_medium=referral&page=upgrade-pr
…14ca3ad2fae7b [Snyk] Upgrade webpack from 5.90.1 to 5.90.2
Signed-off-by: snipe <[email protected]> # Conflicts: # package-lock.json
Signed-off-by: snipe <[email protected]> # Conflicts: # config/version.php
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]> # Conflicts: # public/css/build/app.css # public/css/build/overrides.css # public/css/dist/all.css # public/mix-manifest.json
Signed-off-by: snipe <[email protected]> # Conflicts: # public/css/dist/all.css # public/css/dist/bootstrap-table.css # public/js/dist/bootstrap-table.js # public/mix-manifest.json
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some duplication we can clean up in this.
…Functions merge functions in AssetPresenter.php
@snipe Sorry about that. I believe I've made the requested changes by merging the Dynamic URL Functions in AssetPresenter.php. |
…Functions fixes manufacturer font icon back to globe after accidental change
This looks a lot better, thank you. But c an you retarget to |
Description
This makes all manufacturer links dynamic just like warranty lookup.
Added #14426
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've tested working on latest from my test environment.
Test Configuration:
Checklist: