Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionlogController): correct signature image for s3 bucket #14827

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Jun 5, 2024

Description

This proposal fix issue #10097

Type of change

Signature log is actually possible with an s3 bucket, but the fronted application do not send the correct URL.

How Has This Been Tested?

Tested on eks context with docker image snipe/snipe-it:v6.3.0 (php 8.1.2-1ubuntu2.14)

Checklist:

@fe80 fe80 requested a review from snipe as a code owner June 5, 2024 08:14
Copy link

what-the-diff bot commented Jun 5, 2024

PR Summary

  • Inclusion of Conditional Logic in Display Signal Method
    This update introduces a decision-making instruction to the ActionlogController.php software file. Specifically, the new logic has been added to the displaySig method and is related to the type of disk driver being used. If the software is using an 's3' disk driver (a system used for data storage), it will now redirect to a temporary URL. This URL is generated by a method named temporaryUrl designed for $disk storage. If a disk driver other than 's3' is in use, the software will continue to function as it did before.

@snipe
Copy link
Owner

snipe commented Jun 5, 2024

Nice, thank you!

@snipe snipe merged commit a742105 into snipe:develop Jun 5, 2024
8 checks passed
@fe80
Copy link
Contributor Author

fe80 commented Jun 5, 2024

You are too fast and I'm too bad on copy/past, I miss Illuminate\Support\Facades\Storage, I open a new PR sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants