Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefaced fields with “users” for clarity #14893

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 18, 2024

Saw this pop up in a Rollbar - this just clarifies the users table as the one we want to be sorting against in the left join in scopeUserLocation() to avoid ambiguity.

Copy link

what-the-diff bot commented Jun 18, 2024

PR Summary

  • Improved User Location Search
    The method used for locating users based on specific parameters has been enhanced. This change ensures a more precise search, particularly in cases with complex search criteria. This was achieved by updating the references to column names to be more explicit, thus minimizing any potential for confusion or error in the system during searches.

@snipe snipe merged commit 89a5bbb into develop Jun 18, 2024
7 of 8 checks passed
@snipe snipe deleted the fixes/rb_3792_ambiguous_query branch June 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant