Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage path permissions test #14912

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

bryanlopezinc
Copy link
Contributor

Description

Add storage path permissions test for SettingsController@getSetupIndex

Checklist:

Copy link

what-the-diff bot commented Jun 19, 2024

PR Summary

  • Enhancement of Storage Path Verification
    The SettingsController.php file now includes a method that checks if the application storage path can be written to. This improvement ensures that the system only attempts to write to storage paths that are writable, preventing any unwarranted system errors.

  • Improved Error Handling and User Communication
    In case of directory permission errors (when the storage path is not writable), an appropriate error message will be displayed, contributing to a better understanding of the issues the system may encounter.

  • Intensive Testing for Permission Errors
    Multiple test cases have been added to ShowSetUpPageTest.php to thoroughly test the above changes. These tests focus on verifying the accurate display of directory permission errors and ensuring that no errors are displayed when the storage path is writable, enhancing the robustness and error-free operation of the software.

@snipe
Copy link
Owner

snipe commented Jun 20, 2024

This looks great, thank you!

@snipe snipe merged commit 6dfedac into snipe:develop Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants