Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent attributes order in Print All Assigned report #15069

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

FlorentDotMe
Copy link
Contributor

Description

This issue affects the "Print All Assigned" report generated for a user.

There was an error in the field orders of assets and associated assets, resulting on having the default location in the "model" column for the associated assets. I also replicated to assignedAssets the control functions on the field values as applied on assets.

Before patch:
FIX_before-patch
After patch:
FIX_after-patch

Type of change

  • Bug fix

How Has This Been Tested?

  1. Load the report for an existing user having assets and associated assets
  2. Toggle all columns to show them all
  3. Verify the assigned assets attributes appear correctly

Checklist:

@FlorentDotMe FlorentDotMe requested a review from snipe as a code owner July 11, 2024 10:58
Copy link

welcome bot commented Jul 11, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Jul 11, 2024

PR Summary

  • Improved Error Prevention in Asset Printing
    The code that is responsible for printing assets now checks if the asset's model and category exist before trying to access their properties. This will prevent errors and instead display a message indicating the category or model is invalid when they're missing.

  • Date Formatting Enhancement
    The date of the last checkout of an asset is now displayed using a common date formatting function. This change ensures consistency in how dates are displayed in different parts of the system.

  • Conditional Signature Image Display
    A check has been added to ensure that a signature image is only displayed if there is indeed a signature logged for the asset. This protects against trying to display non-existent images, which could result in errors.

@snipe
Copy link
Owner

snipe commented Jul 11, 2024

Nice work, thanks!

@snipe snipe merged commit 78d24eb into snipe:develop Jul 11, 2024
9 checks passed
Copy link

welcome bot commented Jul 11, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@FlorentDotMe FlorentDotMe deleted the fix_print-all-assets branch August 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants