Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #14821: Add Filter by Asset Tag in Custom Reports #15078

Conversation

Glukose1
Copy link

This PR adds an "Asset Tag" text input field to the create custom asset reports page and the if condition in the Reportscontroller to allow the creation of a report for a specific asset defined by the asset tag.
It only works for one asset tag at a time.

Fixes #14821 only adds the workaround mentioned in the Issue, the rest is still relevant.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested by creating a custom report for a specific asset tag.

Test Configuration:

  • PHP version: 8.2.20
  • MySQL version: mariadb Ver 15.1 Distrib 10.11.6-MariaDB
  • Webserver version: Apache/2.4.59 (Debian)
  • OS version: Debian GNU/Linux 12 (bookworm) Release 12.6

Checklist:

…tion to create report for specific asset filtered by its asset tag

modified:   resources/views/reports/custom.blade.php add asset tag field to create custom report page
@Glukose1 Glukose1 requested a review from snipe as a code owner July 12, 2024 09:58
Copy link

welcome bot commented Jul 12, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Jul 12, 2024

PR Summary

  • Improved Report Filtering
    In the ReportsController.php, we introduced a way of filtering reports based on specific 'asset tags'. If a user wants to view reports related to a specific asset, they can input this asset tag and only see the related reports.

  • User Interface Enhancement
    We updated custom.blade.php by adding a new form field. This allows the user to easily input an 'asset tag' - a unique identifier for a report. The provision of this input field improves the user's navigation and searching experience within the application's report section.

@snipe
Copy link
Owner

snipe commented Jul 12, 2024

Thanks for opening this PR! I think this is probably more confusing than helpful for most use-cases, and it wouldn't include all of the info mentioned in the previous issue anyway though. We'll keep focusing on resolving the original issue.

@snipe snipe closed this Jul 12, 2024
@Glukose1 Glukose1 deleted the features/add_filter_by_asset_tag_to_custom_reports branch July 15, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants