Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EULAs in print user's assets #15088

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

mauro-miatello
Copy link
Contributor

Added EULAs when we want to print all assets assigned to a users and ask him/her to sign.

Description

When we assign assets to a user after on-boarding we deliver a sheet with all his/her assets and ask to sign for confirmation. But there are no EULAs on it, so I added them for each category of asset provided. Hope this can be useful for all users.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Assigned more assets of the same category to be sure not to have EULAs replicated
  • Assigned assets of a category with no EULA to be sure no errors occur
  • Assigned assets of a category with default EULA to be sure no errors occur

Test Configuration:

  • PHP version: 8.0.30
  • MySQL version: MariaDB 10.3.38
  • Webserver version: Apache 2.4.58
  • OS version: Ubuntu 20.04.6 LTS

Checklist:

Added EULAs when we want to print all assets assigned to a users and ask him/her to sign.
Copy link

what-the-diff bot commented Jul 14, 2024

PR Summary

  • Simplify Document Layout
    Extra spaces in the print.blade.php file have been removed to create a neater and more readable structure.

  • Improve Interface with New Button
    A new button adorned with an icon has been added — serving a specific function based on its class definition btn btn-default hidden-print.

  • Expand Options with Collapsible Table Row
    A new table row has been incorporated with a collapse class and designated as eula-row. This provides the option to make additional information available while keeping the interface clean and manageable.

  • Enhanced User Interaction
    Another button featuring an fa fa-eye-slash icon is introduced, providing the user with more interactive possibilities.

  • Intelligent Content Curation
    New PHP programming logic has been implemented to compile unique End User License Agreements (EULA) content, dynamically forming a eulas variable.

  • Smart Content Display
    An 'if' condition has been set up to check if the eulas variable contains any content. If it does, the system iterates through the eulas array, effectively displaying each EULA content to the user.

  • Signature Placeholders Updated
    Changes have been made to the signature placeholders to keep them up-to-date with the current system requirements.

@mauro-miatello
Copy link
Contributor Author

@snipe I've updated my PR after your recent changes. I hope it is ok and can be merged. Thanks.

@snipe
Copy link
Owner

snipe commented Jul 18, 2024

Looks good!

@snipe snipe merged commit ee589ca into snipe:develop Jul 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants