-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Depreciation Percentage as an option #15100
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - can you add in a test or two here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Math seems solid and the now() variable seems to be fine for what we wanna do.
@snipe added a test for amount and percentage 👍 |
Description
This adds the ability to calculate depreciations by percentage. which takes the purchase cost and grabs the percentage and substitutes it in for the amount. the current formula has not changed. this just adds a private method
calculateDepreciation()
to handle this math.A percentage option has been added to Depreciations:
Floor Value as an amount or percentage:
Error if you go outside of 0-100%:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: