Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides the “Disable Other Login Mechanisms” if remote user option isn't checked #15132

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 22, 2024

We recently had a user lock themselves out of their system with a 403 forbidden on the login page because they had enabled this checkbox without actually setting up remote login. This just makes it a little harder for this to happen by putting that environmental variable into a .env and checking that they actually have the remote login checkbox checked in the first place.

Edit: Actually I changed my mind here - For now we'll just check that the remote login option is at least checked.

Copy link

what-the-diff bot commented Jul 22, 2024

PR Summary

  • Inclusion of Remote Login Option in Example Settings
    A new setting, SHOW_REMOTE_LOGIN_ONLY_OPTION, has been added to the example environment configuration file. This will guide users in setting up their environment.

  • Incorporation of New Configuration in App Settings
    The newly introduced option show_remote_login_only_option has been added into the application configuration file. This allows the application to use this setting.

  • Adaptation of Security View Earlier Settings
    The Security settings view has been updated to dynamically show or hide login options. This change is based on the login_remote_user_enabled setting and the newly introduced show_remote_login_only_option. It provides a more tailored login experience for users on the app's security page based on the chosen configuration.

@snipe snipe merged commit efc84ef into develop Jul 22, 2024
8 checks passed
@snipe snipe deleted the fixes/disable_remote_login_force_via_env branch July 22, 2024 09:20
@snipe snipe changed the title Hides the “Disable Other Login Mechanisms” option via env Hides the “Disable Other Login Mechanisms” if remote user option isn't checked Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant